feat(select): add shapes for ionic theme #30016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested review from
brandyscarney and
gnbm
and removed request for
gnbm
brandyscarney
approved these changes
Nov 14, 2024
| // Shapes | ||
| // ---------------------------------------------------------------- | ||
|
|
||
| // Soft |
There was a problem hiding this comment.
Do we need these comments for each shape? It seems the class name already indicates which shape it represents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
ionictheme does not have the styling for shapes.What is the new behavior?
ionicis round, undefined for the other themes.ionictheme.shapefolder.Does this introduce a breaking change?
Other information
Preview